Skip to content

Conversation

CleanCut
Copy link
Contributor

@CleanCut CleanCut commented Sep 21, 2022

Picks up abandoned work from #100870

I would like to do this collaboratively, as there is a lot of work! Here's the process:

  • Comment below that you are willing to help and I will add you as a collaborator to my rust fork (that gives you write access)
  • Indicate which file/task you would like to work on (so we don't duplicate work) from the list below
  • Do the work, push up a commit, comment that you're done with that file/task
  • Repeat until done 😄

Files to Migrate (in compiler/rustc_passes/src/)

Tasks

  • Rebase on current master @CleanCut
  • Review work from the earlier PR and make sure it all looks good
    • compiler/rustc_error_messages/locales/en-US/passes.ftl @CleanCut
    • compiler/rustc_passes/src/check_attr.rs @CleanCut
    • compiler/rustc_passes/src/errors.rs @CleanCut
    • compiler/rustc_passes/src/lang_items.rs @CleanCut
    • compiler/rustc_passes/src/lib.rs @CleanCut
    • compiler/rustc_passes/src/weak_lang_items.rs @CleanCut

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2022
@rust-highfive
Copy link
Contributor

r? @eholk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2022
@CleanCut CleanCut changed the title Migrate rustc passes diagnostics Migrate rustc_passes diagnostics Sep 21, 2022
@CleanCut CleanCut force-pushed the migrate_rustc_passes_diagnostics branch from fb6d205 to b2769b3 Compare September 21, 2022 18:43
@diegooliveira
Copy link
Contributor

I was working on some files from the rustc_passes on this #101815.

@bors

This comment was marked as resolved.

@CleanCut
Copy link
Contributor Author

@diegooliveira Great! Should we merge those changes into this PR? Do you want to collaborate here?

@CleanCut

This comment was marked as outdated.

@CleanCut CleanCut force-pushed the migrate_rustc_passes_diagnostics branch from 5649131 to 4a5d9fc Compare September 23, 2022 16:57
@CleanCut
Copy link
Contributor Author

I rebased on master again. There were lots of little conflicts to resolve.

@CleanCut CleanCut force-pushed the migrate_rustc_passes_diagnostics branch from 4a5d9fc to 50c878d Compare September 23, 2022 17:42
@rust-log-analyzer

This comment has been minimized.

@CleanCut CleanCut force-pushed the migrate_rustc_passes_diagnostics branch from 2941257 to bcf3edb Compare September 24, 2022 18:53
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors

This comment was marked as resolved.

@CleanCut CleanCut force-pushed the migrate_rustc_passes_diagnostics branch from e78d683 to f7e0f65 Compare September 28, 2022 20:14
@CleanCut
Copy link
Contributor Author

Rebased again to resolve new conflicts.

@rust-log-analyzer

This comment has been minimized.

@CleanCut CleanCut force-pushed the migrate_rustc_passes_diagnostics branch from f7e0f65 to 2b29fcf Compare September 29, 2022 18:47
@rust-log-analyzer

This comment has been minimized.

@bors

This comment was marked as resolved.

@CleanCut CleanCut force-pushed the migrate_rustc_passes_diagnostics branch from 34f8ff2 to abeb021 Compare October 2, 2022 00:39
@rust-log-analyzer

This comment has been minimized.

@CleanCut CleanCut force-pushed the migrate_rustc_passes_diagnostics branch from 2c0b53a to 57eba4f Compare October 7, 2022 19:20
@CleanCut
Copy link
Contributor Author

CleanCut commented Oct 9, 2022

@davidtwco Ready for a re-review.

Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit then r=me

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 11, 2022

📌 Commit 5ef1c03 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 11, 2022
…nostics, r=davidtwco

Migrate rustc_passes diagnostics

Picks up abandoned work from rust-lang#100870

I would like to do this collaboratively, as there is a lot of work! Here's the process:

- Comment below that you are willing to help and I will add you as a collaborator to my `rust` fork (that gives you write access)
- Indicate which file/task you would like to work on (so we don't duplicate work) from the list below
- Do the work, push up a commit, comment that you're done with that file/task
- Repeat until done 😄

### Files to Migrate (in `compiler/rustc_passes/src/`)

- [x] check_attr.rs `@CleanCut`
- [x] check_const.rs `@CleanCut`
- [x] dead.rs `@CleanCut`
- [x] debugger_visualizer.rs `@CleanCut`
- [x] diagnostic_items.rs `@CleanCut`
- [x] entry.rs `@CleanCut`
- [x] lang_items.rs `@CleanCut`
- [x] layout_test.rs `@CleanCut`
- [x] lib_features.rs `@CleanCut`
- [x] ~liveness.rs~ `@CleanCut` Nothing to do
- [x] loops.rs `@CleanCut`
- [x] naked_functions.rs `@CleanCut`
- [x] stability.rs `@CleanCut`
- [x] weak_lang_items.rs `@CleanCut`

### Tasks

- [x] Rebase on current `master` `@CleanCut`
- [x] Review work from [the earlier PR](rust-lang#100870) and make sure it all looks good
  - [x] compiler/rustc_error_messages/locales/en-US/passes.ftl `@CleanCut`
  - [x] compiler/rustc_passes/src/check_attr.rs `@CleanCut`
  - [x] compiler/rustc_passes/src/errors.rs `@CleanCut`
  - [x] compiler/rustc_passes/src/lang_items.rs `@CleanCut`
  - [x] compiler/rustc_passes/src/lib.rs `@CleanCut`
  - [x] compiler/rustc_passes/src/weak_lang_items.rs `@CleanCut`
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#102110 (Migrate rustc_passes diagnostics)
 - rust-lang#102187 (Use correct location for type tests in promoted constants)
 - rust-lang#102239 (Move style guide to rust-lang/rust)
 - rust-lang#102578 (Panic for invalid arguments of `{integer primitive}::ilog{,2,10}` in all modes)
 - rust-lang#102811 (Use memset to initialize readbuf)
 - rust-lang#102890 (Check representability in adt_sized_constraint)
 - rust-lang#102913 (unify `IsPattern` and `IsImport` enum in `show_candidates`)
 - rust-lang#102924 (rustdoc: remove unused classes from sidebar links)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 32471a7 into rust-lang:master Oct 12, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 12, 2022
@Enselic Enselic mentioned this pull request Mar 10, 2023
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants